Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-986

Have sanity-bot kvetch if it sees no tests/ change when commit claims to "fix bug"

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • Icon: P4: Low P4: Low
    • None
    • None
    • Sanity Bot
    • None

      Modulo some fuzzy-matching way to recognise when a commit message claims to be fixing a bug, it would make sense to check for at least some change under a tests/ directory - if there's none, then no autotest has been added for the allegedly fixed bug. We can then, at least, help reviewers to notice that something is missing (checking what's not there being harder than checking what is) by having sanity-bot kvetch about the commit message's claim to be fixing a bug.

      We can expect some false positives ("clean up in preparation for fixing bug", etc.), so the kvetching shouldn't be a -1, but a Hint would be justified, at least.

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            Eddy Edward Welbourne
            Eddy Edward Welbourne
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes