Uploaded image for project: 'Qt Quality Assurance Infrastructure'
  1. Qt Quality Assurance Infrastructure
  2. QTQAINFRA-3794

Cherry-pick bot does not correctly parse commit message when querying changes from gerrit

    XMLWordPrintable

Details

    • Bug
    • Resolution: Done
    • P1: Critical
    • None
    • production
    • Cherry-pick bot
    • None
    • 11bc5f7f3a639c4919a26c26966963caaa5f63b9 (qt/qtqa/dev)

    Description

      The Pick-to: commit message parser in cherry-pick bot uses a regex to ensure that the footer sits at the beginning of a line, but it fails to parse this correctly when parsing commit messages returned as a result of a REST query to gerrit.

       -- 

      This appears to be due to the rest responses from gerrit being encoded in plaintext, and newline characters "\n" are interpreted as string literals. This needs to be corrected for, and the bot's parser regex updated to look for either start of line with "^" or the string literal "\n".

       

      This actually appears to be due to using invalid functions to determine the length and content of the set of branches returned by the parser.

      Attachments

        Activity

          People

            daniel.smith Daniel Smith
            daniel.smith Daniel Smith
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: