Uploaded image for project: 'Qt Mobility'
  1. Qt Mobility
  2. QTMOBILITY-715

Dead code in QValueSpaceManager::install

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Not Evaluated Not Evaluated
    • 1.2.0
    • 1.1.0
    • Publish & Subscribe
    • None
    • bd106b2fe0915e34f3bb5a90aff14743184571da

      For loop in QValueSpaceManager::install won't be ever run, because inserted is always true, -1 in this case, on the first try.

      
      void QValueSpaceManager::install(QAbstractValueSpaceLayer * layer)
      {
          Q_ASSERT(Uninit == type);
          Q_ASSERT(layer);
          unsigned int cOrder = layer->order();
          int inserted = -1;
          for(int ii = 0; !inserted && ii < layers.count(); ++ii) {
              unsigned int lOrder = layers.at(ii)->order();
              Q_ASSERT(layer != layers.at(ii));
              if(lOrder < cOrder) {
                  // Do nothing
              } else if(lOrder == cOrder) {
                  if(layers.at(ii)->id() > layer->id()) {
                      layers.insert(ii, layer);
                      inserted = ii;
                  }
              } else if(lOrder > cOrder) {
                  layers.insert(ii, layer);
                  inserted = ii;
              }
          }
      
          if(-1 == inserted) {
              inserted = layers.count();
              layers.append(layer);
          }
      }
      
      

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            xizzhu Xizhi Zhu (Steven)
            vihria Tomi VihriƤ
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes