Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-26651

textDocument/didChange doesn't seem to work

XMLWordPrintable

    • 41fe7eec6566992adf06df103564a50311b765fe (qt-creator/qt-creator/6.0)

      Qt Creator does not seem to generate textDocument/didChange events.

      It seems to be supported, but there is this suspicious line in src/plugins/languageclient/client.cpp which seems to have None and Full swapped:

      void Client::documentContentsChanged(TextEditor::TextDocument *document,
                                     int position,
                                     int charsRemoved,
                                     int charsAdded)
{
    if (!m_openedDocument.contains(document) || !reachable())
        return;
    const QString method(DidChangeTextDocumentNotification::methodName);
    TextDocumentSyncKind syncKind = m_serverCapabilities.textDocumentSyncKindHelper();
    if (Utils::optional<bool> registered = m_dynamicCapabilities.isRegistered(method)) {
        syncKind = registered.value() ? TextDocumentSyncKind::None : TextDocumentSyncKind::Full; <-- HERE

        For Gerrit Dashboard: QTCREATORBUG-26651
        # Subject Branch Project Status CR V
        384525,1 LanguageClient: fix textDocument/didChange master qt-creator/qt-creator Status: DEFERRED +1 0
        384554,2 LanguageClient: fix textDocument/didChange 6.0 qt-creator/qt-creator Status: MERGED +2 0

            davschul David Schulz
            poikelin Joni Poikelin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes