Uploaded image for project: 'Qt Creator'
  1. Qt Creator
  2. QTCREATORBUG-17485

Add unit tests for class QtOutputFormatterPrivate

XMLWordPrintable

    • Icon: Suggestion Suggestion
    • Resolution: Done
    • Icon: P3: Somewhat important P3: Somewhat important
    • None
    • Qt Creator 4.2.0
    • Android Support
    • None

      The regular expressions in QtOutputFormatterPrivate might break again:

          QtOutputFormatterPrivate(Project *proj)
              : qmlError(QLatin1String("(" QML_URL_REGEXP    // url
                                        ":\\d+"           // colon, line
                                        "(?::\\d+)?)"     // colon, column (optional)
                                        "[: \t]"))        // colon, space or tab
              , qtError(QLatin1String("Object::.*in (.*:\\d+)"))
              , qtAssert(QLatin1String("ASSERT: .* in file (.+, line \\d+)"))
              , qtAssertX(QLatin1String("ASSERT failure in .*: \".*\", file (.+, line \\d+)"))
              , qtTestFail(QLatin1String("^   Loc: \\[(.*)\\]"))
              , project(proj)
          {
          }
      

      Having unit might help to notice this. See Tobias' comment in https://codereview.qt-project.org/122647/

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            vikas Vikas Pachdha
            rlohning Robert Löhning
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                There are no open Gerrit changes