Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-86834

OSM tile fetcher and provider qWarnings that should be qInfos

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • P2: Important
    • None
    • 5.15.1
    • None

    Description

      When using

      QT_FATAL_WARNINGS=1
      

      I stumbled upon a few qWarnings that should, in my point of view, be qInfos.

      In qgeotilefetcherosm.cpp

      #L121

      void QGeoTileFetcherOsm::onProviderResolutionFinished(const QGeoTileProviderOsm *provider)
      {
          if ((m_ready = providersResolved(m_providers))) {
              qWarning("QGeoTileFetcherOsm: all providers resolved");
              readyUpdated();
          }
          emit providerDataUpdated(provider);
      }
      

      and a few lines below #L130

      void QGeoTileFetcherOsm::onProviderResolutionError(const QGeoTileProviderOsm *provider)
      {
          if ((m_ready = providersResolved(m_providers))) {
              qWarning("QGeoTileFetcherOsm: all providers resolved");
              readyUpdated();
          }
          emit providerDataUpdated(provider);
      }
      

      And in qgeotileproviderosm.cpp
      on L#479

      const QJsonValue enabled = json.value(QLatin1String("Enabled"));
      if (enabled.isBool() && ! enabled.toBool()) {
          qWarning() << "QGeoTileProviderOsm: Tileserver disabled" << "at "<<m_urlRedirector;
          return;
      }
      

      I'm not sure why these cases should be regarded as warnings since they will be triggered even if everything goes correctly.

      Attachments

        Activity

          People

            paangele Paolo Angelelli
            imbachb B Imbach
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: