Uploaded image for project: 'Qt'
  1. Qt
  2. QTBUG-74286

Reimplement QLocaleData::stringTo(Uns|)LongLong() to take size of string

XMLWordPrintable

    • All
    • 13
    • Foundation_Sprint 41 (Team 1)

      In the process, remove the dead-code QLocaleData::stringToDouble and, deploying this so as to make QByteArray::nulTerminated(), remove that monstrosity, too.

      As stringToLongLong() and stringToUnsLongLong() currently don't take their size, callers are obliged to '\0'-terminate their data before calling; this may oblige callers to copy the data if the subject string is not the tail of the actual string of which it is a part.

      Furthermore, as these two functions (lacking knowledge of the data's size) necessarily stop at the first '\0' in the data, they may fail to recognise a '\0' internal to the data, along with any characters after it within the intended size, as "trailing junk". thiago says this introduces security concerns.

        For Gerrit Dashboard: QTBUG-74286
        # Subject Branch Project Status CR V

            Eddy Edward Welbourne
            Eddy Edward Welbourne
            Vladimir Minenko Vladimir Minenko
            Alex Blasche Alex Blasche
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 1 week
                1w
                Remaining:
                Remaining Estimate - 1 week
                1w
                Logged:
                Time Spent - Not Specified
                Not Specified

                  There are no open Gerrit changes