Details
-
Task
-
Resolution: Done
-
P2: Important
-
None
-
None
Description
src/widgets/kernel/qsizepolicy.h
// ### Qt 5: merge these two constructors (with type == DefaultType) QSizePolicy(Policy horizontal, Policy vertical) : data(horizontal | (vertical << HSize)) { } QSizePolicy(Policy horizontal, Policy vertical, ControlType type) : data(horizontal | (vertical << HSize)) { setControlType(type); } ... quint32 data; /* Qt5: Use bit flags instead, keep it here for improved readability for now. We can maybe change it for Qt4, but we'd have to be careful, since the behaviour is implementation defined. It usually varies between little- and big-endian compilers, but it might also not vary. quint32 horzPolicy : 4; quint32 vertPolicy : 4; quint32 hfw : 1; quint32 ctype : 5; quint32 wfh : 1; quint32 padding : 1; // we cannot use the highest bit quint32 verStretch : 8; quint32 horStretch : 8; */
These comments should either be actioned for Qt 5.0.0 (if source-compatibility can be maintained), removed, or changed to Qt 6 to-do's.
Note that addressing the second item should also involve making the parameter types of the setHorizontalStretch() and setVerticalStretch() methods match those of the horizontalStretch() and verticalStretch() methods.
Attachments
Issue Links
- resulted from
-
QTBUG-23524 [API] Grep the source for Qt5 todo items
- Closed