Uploaded image for project: 'Qt Safe Renderer'
  1. Qt Safe Renderer
  2. QSR-1162

Fix Clan-tidy warning for the runtime

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: P3: Somewhat important P3: Somewhat important
    • QSR 2.1
    • QSR 1.2
    • Runtime
    • None

      There is a warning about the QSafelayoutReader::readData function which should be considered to fix.

      The following warning is from the QSafeLayoutReader::readData. This function works as expected the function is a pure virtual function.

      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:88:5: Calling 'QSafeLayoutFileReader::readData'
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94:35: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94:35: warning: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
      1: Calling 'QSafeLayoutFileReader::readData' in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:88
      2: Call to virtual method 'QSafeLayoutFileReader::readDataFromFile' during construction bypasses virtual dispatch in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutfilereader.cpp:94
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:81:5: Calling 'QSafeLayoutResourceReader::readData'
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88:35: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch
      E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88:35: warning: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
      1: Calling 'QSafeLayoutResourceReader::readData' in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:81
      2: Call to virtual method 'QSafeLayoutResourceReader::readDataFromFile' during construction bypasses virtual dispatch in E:/teholapp/work/qtsaferenderer/src/saferenderer/qsafelayoutresourcereader.cpp:88

       

          For Gerrit Dashboard: QSR-1162
          # Subject Branch Project Status CR V

              qtsaferendererteam Qt Safe Renderer Team
              teemu.holappa Teemu Holappa
              Miao Luo Miao Luo
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:

                  There are no open Gerrit changes