Uploaded image for project: 'Coin'
  1. Coin
  2. COIN-327

Remove firewall configuration from the bootstrap agent and agent

    XMLWordPrintable

Details

    • Task
    • Resolution: Unresolved
    • P2: Important
    • None
    • None
    • Agent
    • None

    Description

      I'm noting this Jira ticket down in order to remember reverting this commit:

      https://codereview.qt-project.org/c/qtqa/tqtc-coin-ci/+/246091

      As far as I understand the image provisioning, this belongs to coin-setup which should incorporate the change in Tier1 images.

      I would have already tried reverting the commit, but I see there is relevant code in coin-setup from 2017 which is apparently not functioning properly:

              log.Println("Disabling firewall")
              for _, profile := range []string{"StandardProfile", "DomainProfile", "PublicProfile"} {
                      key, err = registry.OpenKey(registry.LOCAL_MACHINE, `SYSTEM\CurrentControlSet\Services\SharedAccess\Parameters\FirewallPolicy\`+profile,
                              registry.SET_VALUE)
                      if err != nil {
                              log.Println(fmt.Sprintf("Error locating firewall %s registry key: %s\nThis is probably not a Windows >=8 machine?", profile, err))
                      } else {
                              key.SetDWordValue("DisableNotifications", 1)
                              key.SetDWordValue("DoNotAllowExceptions", 1)
                              key.SetDWordValue("EnableFirewall", 0)
                              key.Close()
                      }
              }
      

      Attachments

        Activity

          People

            tosaario Toni Saario
            jimis Dimitrios Apostolou
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: