Uploaded image for project: 'Qt Cloud'
  1. Qt Cloud
  2. CLOUD-334

Onboarding - when we are adding variables, secrets should be marked as masked

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: P2: Important P2: Important
    • None
    • None
    • Backend , GitLab
    • None

      We are adding variables in the function "addVariablesToProject" in _onboarding module. 

       

      We should mark the secrets as masked. 

      def addVariablesToProject (self, variable_obj):        
    for variable in variable_obj.keys():                
        qt_gemini_logger.info("Adding CI/CD variable '{0}'".format(variable))              
        try:
           self.getProjectHandle().variables.create({'key': variable, 'value': variable_obj[variable]})
           # FIXME: define secret variables as masked
        except (gitlab.GitlabError, gitlab.GitlabCreateError) as e:                           
            qt_gemini_logger.warning("Cannot add '{0}'".format(variable))                    
            #FIXME: should we exit from here or should we continue?

        No reviews matched the request. Check your Options in the drop-down menu of this sections header.

            tpyssysa Tino Pyssysalo
            as33ms Aseem Shakuntal
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:

                There are no open Gerrit changes