Uploaded image for project: 'Qt Cloud'
  1. Qt Cloud
  2. CLOUD-215

Refactor scripts used in dockerfiiles

    XMLWordPrintable

Details

    • Task
    • Resolution: Won't Do
    • P2: Important
    • None
    • None
    • General
    • None
    • Gemini sprint 7

    Description

      Some functions/files are sourced and absolute path is needed. I'm quite sure that relative path there is enough. We can save some lines with that.

      this_script_dir=$(dirname $0)
      
      ##### COMMON INCLUDES FOR SCRIPTS ######
      . $this_script_dir/functions.sh
      ##### COMMON INCLUDES FOR SCRIPTS ######
      

      can be replaced with

      ##### COMMON INCLUDES FOR SCRIPTS ######
      . functions.sh

      I would also make a comment little less blocky.

      Attachments

        Activity

          People

            as33ms Aseem Shakuntal
            kgorecki Krzysztof Gorecki
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: